Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure SDK Instrumentation (Storage + Queue) #1316

Merged
merged 17 commits into from
Oct 1, 2021
Merged

Azure SDK Instrumentation (Storage + Queue) #1316

merged 17 commits into from
Oct 1, 2021
+712 −1

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 31, 2021 •
edited
Loading

Related issues

Closes #1028
Closes #1029

@basepi basepi self-assigned this Aug 31, 2021
@basepi basepi added this to the 7.16 milestone Aug 31, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Aug 31, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-01T09:22:47.067+0000

  • Duration: 28 min 41 sec

  • Commit: cb81378

Test stats 🧪

Test Results
Failed 0
Passed 9603
Skipped 8836
Total 18439

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@basepi basepi changed the title [WIP] Azure SDK Instrumentation [WIP] Azure SDK Instrumentation (Storage + Queue) Sep 29, 2021
@basepi basepi mentioned this pull request Sep 30, 2021
Open
4 tasks
@basepi basepi marked this pull request as ready for review September 30, 2021 17:44
@basepi basepi requested a review from beniwohli September 30, 2021 17:44
@basepi
Copy link
Contributor Author

basepi commented Sep 30, 2021

Note that the tests included are not actually being run (yet) -- see #1348 for that technical debt. But they all pass if you set up your own "AZURE_STORAGE_CONNECTION_STRING" env variable with the connection string for an Azure storage account.

beniwohli
beniwohli approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are some humongous if-statements :D good work on assembling those! Would it make sense to write unit tests (as in, they can run without an azure service) for those? Maybe even driven by a JSON file that can be shared amongst agents.

@basepi basepi mentioned this pull request Oct 1, 2021
Open
@basepi
Copy link
Contributor Author

basepi commented Oct 1, 2021

Excellent idea. I decided to put the issue in the apm repo since it's a cross-agent thing: elastic/apm#519

@basepi basepi merged commit 9cf8e57 into elastic:master Oct 1, 2021
@basepi basepi changed the title [WIP] Azure SDK Instrumentation (Storage + Queue) Azure SDK Instrumentation (Storage + Queue) Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beniwohli beniwohli beniwohli approved these changes

Assignees

@basepi basepi

Labels
agent-python
Projects
None yet
Milestone
7.16
Development

Successfully merging this pull request may close these issues.

[META 410] Instrumentation for Azure Queue [META 410] Instrumentation for Azure Storage
3 participants
@basepi @apmmachine @beniwohli